Skip to content

feat: program details pane #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 23, 2025
Merged

feat: program details pane #728

merged 13 commits into from
May 23, 2025

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented May 16, 2025 •
edited
Loading

PULL REQUEST

Summary

Add a program details side panel when a user clicks on a program area's name.

Note, this design doesn't quite match figma, but instead is consistent with the user one and we can iterate later

Related Issue

Fixes #727

Acceptance Criteria

Side panel with the following:

  • Name
  • Created date information [DD/MM/YYYY 0:00 (User Time Zone), ie. 3/4/25 8:30 AM PST)
  • Number of conditions included in the program area
  • List of conditions in the program area
  • Ability to close the side panel using the (X)

Additional Information

image

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.10%. Comparing base (8fc9e3f) to head (74c0c35).

Files with missing lines Patch % Lines
.../ecr-viewer/src/app/admin/program/ProgramTable.tsx 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   87.63%   91.10%   +3.47%     
==========================================
  Files         281      146     -135     
  Lines       14410     5477    -8933     
  Branches      950      947       -3     
==========================================
- Hits        12628     4990    -7638     
+ Misses       1765      470    -1295     
  Partials       17       17
Flag Coverage Δ
ecr-viewer 93.01% <92.30%> (-0.01%) ⬇️
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.45% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcmcgrath13 mcmcgrath13 changed the title feat: wip - program details pane feat: program details pane May 19, 2025
@mcmcgrath13 mcmcgrath13 marked this pull request as ready for review May 19, 2025 15:13
@mcmcgrath13 mcmcgrath13 requested a review from a team as a code owner May 19, 2025 15:13
@mcmcgrath13 mcmcgrath13 requested review from akasper and JNygaard-Skylight and removed request for a team May 19, 2025 15:13
@mcmcgrath13 mcmcgrath13 added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit c01d93c May 23, 2025
17 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/feat-prog-deets branch May 23, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JNygaard-Skylight JNygaard-Skylight JNygaard-Skylight approved these changes

@akasper akasper Awaiting requested review from akasper akasper is a code owner automatically assigned from CDCgov/dibbs-ecr-viewer-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Program Management UI: View Program Area
3 participants
@mcmcgrath13 @codecov-commenter @JNygaard-Skylight